Repository navigation
CI: Test under pnpm's isolated node_modules #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit · Root devDependencies stay resolvable from every workspace package, so this job can't catch those being undeclared
The comment says pnpm's isolated
node_modulescatches undeclared dependencies. That doesn't hold for anything in the rootpackage.jsondevDependencies. pnpm links those into<root>/node_modules, and Node's resolution walks up frompackages/<pkg>/to that folder.So if a workspace package starts using
nullthrows,invariant,debug,@babel/core,@babel/types,source-map,flow-parseror similar without declaring it, every step of this job still passes.The job still adds value. It catches undeclared packages that resolved only through Yarn's hoisting from another workspace's dependencies, including in tests, scripts and string-based
require.resolvelookups. Theimport/no-extraneous-dependencieslint rule already covers static imports inpackages/*/src.Suggested fix: narrow the comment, e.g. "catches dependencies that only resolve via hoisting from other packages; root devDependencies remain visible to all workspaces".
Reproduced: In a pnpm 12 scratch install of the head (
pnpm importthenpnpm install --frozen-lockfile),packages/metro-cache/package.jsondoesn't declarenullthrows. Even so,require.resolve('nullthrows', {paths: ['packages/metro-cache/src']})resolves tonode_modules/.pnpm/nullthrows@1.1.1/...through the root link. · iddcbeedcb