Skip to content

Deploy 0.341.0 to xplat (#2255) - #2255

Merged
meta-codesync[bot] merged 1 commit into
react:mainfrom
panagosg7:export-D133315654
Nov 20, 2026
Merged

meta-codesync[bot] merged 1 commit into
react:mainfrom
panagosg7:export-D133315654

Conversation

@panagosg7

@panagosg7 panagosg7 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary:
X-link: meta/relay#5459

X-link: react/react-native#60165

changelog

Library definitions

Flow 0.341.0 rejects the explicit exact object syntax {| |} and unnamed function type parameters, and checks type applications inside generic definitions. Relay's flow-typed/ definitions for Babel, chalk and Jest now write exact objects as { } (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's traverse is named. In the shared child_process definition used by Metro and React Native, MaybeStream infers E from the optional stdio option, so E includes void; its indexed accesses now read NonNullable<E>[FD].

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2026
@meta-codesync

meta-codesync Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@panagosg7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D133315654.

panagosg7 added a commit to panagosg7/react-native that referenced this pull request Nov 19, 2026
Summary:
X-link: meta/relay#5459

Pull Request resolved: react#60165

X-link: react/metro#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Metro review: Looks good

Risk: low · Commit: 0486564 · 2 commands run

This PR moves Metro's Flow version from 0.340.0 to 0.341.0 in .flowconfig, flow-bin and the lockfile. It also changes the shared child_process libdef so MaybeStream indexes NonNullable<E>[FD], because the inferred stdio type can include void. Typecheck is clean on 0.341.0, and a type-level probe shows spawn's stdio stream types still resolve as before, so nothing here blocks the change.

No findings.

Verified
  • ✅ node_modules/.bin/flow version && yarn typecheck — Flow 0.341.0 is installed in the head checkout. No errors.
  • ✅ yarn flow check (with probe packages/metro/src/__review__/stdio-check.js) — Checks the spawn stdio types: ['pipe','pipe','ignore'] gives stdout stream$Readable and stderr null; omitting options gives a stream; 'inherit' gives null; a $FlowExpectedError on stderr-as-stream fires as expected.

Not run: Benchmarks: this is a devDependency and type-only change with no runtime effect. I did not run Jest, because no runtime code changed. The flow-api-translator, flow-eslint, flow-estree and flow-parser pins stay at 0.340.0. That matches how these bumps are usually staged, and I did not check them against 0.341. The PR changes package.json and yarn.lock, so it needs a Meta import, but it was exported from Meta's monorepo anyway.

Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call.

@robhogan robhogan added the Auto review: Good The Metro review bot found nothing to change at this head label Nov 20, 2026
panagosg7 added a commit to panagosg7/metro that referenced this pull request Nov 20, 2026
Summary:
X-link: meta/relay#5459

X-link: react/react-native#60165

Pull Request resolved: react#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654
@meta-codesync meta-codesync Bot changed the title Deploy 0.341.0 to xplat Deploy 0.341.0 to xplat (#2255) Nov 20, 2026
panagosg7 added a commit to panagosg7/react-native that referenced this pull request Nov 20, 2026
Summary:
X-link: meta/relay#5459

Pull Request resolved: react#60165

X-link: react/metro#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654
Summary:
X-link: meta/relay#5459

X-link: react/react-native#60165

Pull Request resolved: react#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654
panagosg7 added a commit to panagosg7/react-native that referenced this pull request Nov 20, 2026
Summary:
X-link: meta/relay#5459

Pull Request resolved: react#60165

X-link: react/metro#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654
@meta-codesync
meta-codesync Bot merged commit 8c842c1 into react:main Nov 20, 2026
18 of 19 checks passed
meta-codesync Bot pushed a commit to react/react-native that referenced this pull request Nov 20, 2026
Summary:
X-link: meta/relay#5459


X-link: react/metro#2255

[changelog](https://github.com/facebook/flow/blob/main/Changelog.md)

## Library definitions

Flow 0.341.0 rejects the explicit exact object syntax `{| |}` and unnamed function type parameters, and checks type applications inside generic definitions. Relay's `flow-typed/` definitions for Babel, chalk and Jest now write exact objects as `{ }` (objects are exact by default, so the meaning is unchanged), and the second parameter of Babel's `traverse` is named. In the shared `child_process` definition used by Metro and React Native, `MaybeStream` infers `E` from the optional `stdio` option, so `E` includes `void`; its indexed accesses now read `NonNullable<E>[FD]`.

Changelog: [Internal]

Reviewed By: SamChou19815

Differential Revision: D133315654

Pull Request resolved: #60165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto review: Good The Metro review bot found nothing to change at this head CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported needs-meta-import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants