Skip to content

yarn.lock: Upgrade eslint-plugin-jsx-a11y to 6.10.2 to drop core-js-pure - #2270

Open
robhogan wants to merge 3 commits into
robhogan/remove-type-only-edgesfrom
robhogan/jsx-a11y-drop-core-js-pure
Open

robhogan wants to merge 3 commits into
robhogan/remove-type-only-edgesfrom
robhogan/jsx-a11y-drop-core-js-pure

Conversation

@robhogan

@robhogan robhogan commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

eslint-plugin-jsx-a11y 6.6.0 (a lint dependency) depends on aria-query 4, which pulls in @babel/runtime-corejs3 and core-js-pure.

Its postinstall only prints a funding banner, but pnpm 11+ fails the install over the unapproved build script, unless an exemption is made.

We can avoid that with a yarn.lock-only update to eslint-plugin-jsx-a11y to 6.10, which bumps aria-query and drops @babel/runtime-corejs3 and core-js-pure.

Every newly locked version satisfies a 14-day minimum release age, so this should pass Meta dep checks.

Changelog: Internal

Test plan:
yarn why core-js-pure finds nothing, and yarn lint passes with the same single existing warning. With #2110 on top and its allowBuilds removed, pnpm install --frozen-lockfile (pnpm 12.15.0) succeeds; before this, it fails with ERR_PNPM_IGNORED_BUILDS for core-js-pure@3.49.0.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2026
robhogan added a commit that referenced this pull request Nov 21, 2026
Metro is developed with Yarn v1 and `yarn.lock` stays the source of truth, but this lets pnpm users work in the repo by generating a lockfile with `pnpm import`. It adds a `pnpm-workspace.yaml` (pnpm doesn't read `workspaces` from `package.json`), git-ignores the generated `pnpm-lock.yaml` and documents the two commands in the README.

The workspace file also sets `linkWorkspacePackages` - without it, pnpm (since v9) resolves our exact-version internal dependencies like `"metro-core": "0.88.0"` from npm, which fails after a version bump that isn't published yet. pnpm 11+ also fails the install over a dependency's unapproved build script, and with #2270 none has one.

Linking workspace packages gives each one its own `node_modules` pointing at its siblings, where Yarn hoists them. Those links form cycles (`packages/metro-config/node_modules/metro` -> `packages/metro`, whose `node_modules/metro-config` links back), which Flow crawls without hanging since 0.341.0, and with #2257 no type imports rely on hoisting, so Flow needs no config changes.

Changelog: Internal

Test plan:
On a fresh clone of this PR, with each of pnpm 11.28.12 and 12.21.0, `pnpm import` then `pnpm install --frozen-lockfile` succeed, `packages/metro/node_modules/metro-core` is a symlink to `../../metro-core`, and `pnpm exec jest --no-watchman packages` passes (167 suites, 3262 tests), as do `build`, `lint`, `format-check`, `verify-api-snapshots`, `typecheck-ts` and `test-smoke`.

`flow check` passes under pnpm 12.15.0 and under Yarn.
@robhogan
robhogan added this pull request to stack #2271 November 21, 2026 09:23
robhogan added a commit that referenced this pull request Nov 21, 2026
Metro is developed with Yarn v1 and `yarn.lock` stays the source of truth, but this lets pnpm users work in the repo by generating a lockfile with `pnpm import`. It adds a `pnpm-workspace.yaml` (pnpm doesn't read `workspaces` from `package.json`), git-ignores the generated `pnpm-lock.yaml` and documents the two commands in the README.

The workspace file also sets `linkWorkspacePackages` - without it, pnpm (since v9) resolves our exact-version internal dependencies like `"metro-core": "0.88.0"` from npm, which fails after a version bump that isn't published yet. pnpm 11+ also fails the install over a dependency's unapproved build script, and with #2270 none has one.

Linking workspace packages gives each one its own `node_modules` pointing at its siblings, where Yarn hoists them. Those links form cycles (`packages/metro-config/node_modules/metro` -> `packages/metro`, whose `node_modules/metro-config` links back), which Flow crawls without hanging since 0.341.0, and with #2257 no type imports rely on hoisting, so Flow needs no config changes.

Changelog: Internal

Test plan:
On a fresh clone of this PR, with each of pnpm 11.28.12 and 12.21.0, `pnpm import` then `pnpm install --frozen-lockfile` succeed, `packages/metro/node_modules/metro-core` is a symlink to `../../metro-core`, and `pnpm exec jest --no-watchman packages` passes (167 suites, 3262 tests), as do `build`, `lint`, `format-check`, `verify-api-snapshots`, `typecheck-ts` and `test-smoke`.

`flow check` passes under pnpm 12.15.0 and under Yarn.
robhogan added a commit that referenced this pull request Nov 21, 2026
Metro is developed with Yarn v1 and `yarn.lock` stays the source of truth, but this lets pnpm users work in the repo by generating a lockfile with `pnpm import`. It adds a `pnpm-workspace.yaml` (pnpm doesn't read `workspaces` from `package.json`), git-ignores the generated `pnpm-lock.yaml` and documents the two commands in the README.

The workspace file also sets `linkWorkspacePackages` - without it, pnpm (since v9) resolves our exact-version internal dependencies like `"metro-core": "0.88.0"` from npm, which fails after a version bump that isn't published yet. pnpm 11+ also fails the install over a dependency's unapproved build script, and with #2270 none has one.

Linking workspace packages gives each one its own `node_modules` pointing at its siblings, where Yarn hoists them. Those links form cycles (`packages/metro-config/node_modules/metro` -> `packages/metro`, whose `node_modules/metro-config` links back), which Flow crawls without hanging since 0.341.0, and with #2257 no type imports rely on hoisting, so Flow needs no config changes.

Changelog: Internal

Test plan:
On a fresh clone of this PR, with each of pnpm 11.28.12 and 12.21.0, `pnpm import` then `pnpm install --frozen-lockfile` succeed, `packages/metro/node_modules/metro-core` is a symlink to `../../metro-core`, and `pnpm exec jest --no-watchman packages` passes (167 suites, 3262 tests), as do `build`, `lint`, `format-check`, `verify-api-snapshots`, `typecheck-ts` and `test-smoke`.

`flow check` passes under pnpm 12.15.0 and under Yarn.
@robhogan robhogan changed the title Upgrade eslint-plugin-jsx-a11y to 6.10.2 to drop core-js-pure yarn.lock: Upgrade eslint-plugin-jsx-a11y to 6.10.2 to drop core-js-pure Nov 21, 2026
@robhogan
robhogan requested review from huntie and vzaidman November 21, 2026 09:58
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Metro review: Looks good

Risk: low · Commit: 8c1cfb2 · 5 commands run

This is a yarn.lock-only update that moves eslint-plugin-jsx-a11y from 6.6.0 to 6.10.2. It takes aria-query from 4 to 5, which drops @babel/runtime-corejs3, core-js-pure and has. It also brings in a few in-range transitive bumps, and the later commits on the branch dedupe them. A frozen-lockfile Yarn 1 install succeeds, core-js-pure is gone from the installed tree, lint output is unchanged, every newly locked version is more than 14 days old, and I found nothing to change.

No findings.

Verified
  • ✅ yarn@1.22.22 install --frozen-lockfile --ignore-scripts (package_manager, scratch copy of head) — The lockfile is consistent with package.json. Neither core-js-pure nor @‍babel/runtime-corejs3 is in the installed node_modules.
  • ✅ yarn lint (head checkout) — 0 errors, plus the one existing lint/strictly-null warning in JsFileWrapping-test.js.
  • ✅ npx yarn-deduplicate@6.0.2 --list yarn.lock (head) — It lists only existing duplicates outside this diff (debug, semver, acorn and others). The PR adds no new duplicate entries.
  • ✅ npm view <pkg> time for eslint-plugin-jsx-a11y, axe-core, call-bind, es-abstract, es-object-atoms — The newest are axe-core 4.14.0 (2026-10-05) and es-object-atoms 1.1.2 (2026-05-22). All are at least 14 days old.
  • ✅ grep eslint peer range in node_modules/eslint-plugin-jsx-a11y/package.json — The peer range ^3 || ... || ^9 covers the repo's eslint 8.57.0.

Not run: I didn't reproduce the pnpm 12 claim (no ERR_PNPM_IGNORED_BUILDS with #2110 on top), because #2110 isn't part of this checkout. No benchmarks: the change touches only lint devDependencies, with no runtime or published-package effect. The change touches yarn.lock, so it needs a Meta import.

Automated review by Claude. Advisory only: it never approves or blocks, and a maintainer makes the call.

`eslint-plugin-jsx-a11y` 6.6.0 depends on `aria-query` 4, which pulls in `@babel/runtime-corejs3` and `core-js-pure`. Its postinstall only prints a funding banner, but pnpm 11+ fails the install over the unapproved build script. 6.10.2 is within our existing `^6.6.0` range (we only have it to satisfy `eslint-config-fb-strict`'s peer dependency) and uses `aria-query` 5, which has no dependencies.

This is a `yarn.lock`-only change: only the plugin's entry was re-resolved, so other locked versions are kept wherever they still satisfy their ranges.

Changelog: Internal
@robhogan
robhogan force-pushed the robhogan/jsx-a11y-drop-core-js-pure branch from 4f24707 to 8c1cfb2 Compare November 21, 2026 10:46
robhogan added a commit that referenced this pull request Nov 21, 2026
Metro is developed with Yarn v1 and `yarn.lock` stays the source of truth, but this lets pnpm users work in the repo by generating a lockfile with `pnpm import`. It adds a `pnpm-workspace.yaml` (pnpm doesn't read `workspaces` from `package.json`), git-ignores the generated `pnpm-lock.yaml` and documents the two commands in the README.

The workspace file also sets `linkWorkspacePackages` - without it, pnpm (since v9) resolves our exact-version internal dependencies like `"metro-core": "0.88.0"` from npm, which fails after a version bump that isn't published yet. pnpm 11+ also fails the install over a dependency's unapproved build script, and with #2270 none has one.

Linking workspace packages gives each one its own `node_modules` pointing at its siblings, where Yarn hoists them. Those links form cycles (`packages/metro-config/node_modules/metro` -> `packages/metro`, whose `node_modules/metro-config` links back), which Flow crawls without hanging since 0.341.0, and with #2257 no type imports rely on hoisting, so Flow needs no config changes.

Changelog: Internal

Test plan:
On a fresh clone of this PR, with each of pnpm 11.28.12 and 12.21.0, `pnpm import` then `pnpm install --frozen-lockfile` succeed, `packages/metro/node_modules/metro-core` is a symlink to `../../metro-core`, and `pnpm exec jest --no-watchman packages` passes (167 suites, 3262 tests), as do `build`, `lint`, `format-check`, `verify-api-snapshots`, `typecheck-ts` and `test-smoke`.

`flow check` passes under pnpm 12.15.0 and under Yarn.
@robhogan
robhogan removed this pull request from stack #2271 November 21, 2026 10:47
@robhogan
robhogan added this pull request to stack #2273 November 21, 2026 10:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. needs-meta-import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant