[release-1.10] fix: honor init container order in spec.deployment.patch [RHDHBUGS-2900]#2865
Merged
rm3l merged 10 commits intoMay 19, 2026
Conversation
Use ListIncreaseDirection: MergeOptionsListPrepend so user-specified init containers are prepended rather than appended, allowing them to run before install-dynamic-plugins. Assisted-by: Claude
…GS-2900] Add TestInitContainerOrderInSpecDeployment to verify user-specified init containers are prepended before install-dynamic-plugins. Update existing TestMergeFromSpecDeployment assertions to match prepend behavior. Document list ordering semantics in docs/configuration.md. Assisted-by: Claude
…S-2900] Show how to place a custom init container after install-dynamic-plugins by referencing the existing container by name first in the patch. Assisted-by: Claude
…BUGS-2900] Cover both ordering directions in TestInitContainerOrderInSpecDeployment: prepending before and anchoring after install-dynamic-plugins. Assisted-by: Claude
…HDHBUGS-2900] kyaml's merge2 silently ignores $patch directives (e.g. $patch: replace) when ListIncreaseDirection is set to ListPrepend. Work around this by doing a second merge pass with default options to apply $patch directives, after the first pass has already established correct list item positions. Assisted-by: Claude
… [RHDHBUGS-2900] Recommend listing all init containers explicitly in the desired order, and note that $setElementOrder is not supported by the kyaml library. Co-authored-by: Gennady Azarenkov <gazarenkov@gmail.com> Assisted-by: Claude
…BUGS-2900] Introduce rhdh.redhat.com/deployment-patch-list-merge-mode annotation to control list merge behavior in spec.deployment.patch. Default behavior (append) is preserved; setting the annotation to "prepend" enables ListPrepend with a two-pass merge workaround for $patch directives. Co-authored-by: Gennady Azarenkov <gazarenkov@gmail.com> Assisted-by: Claude
…S-2900] Assisted-by: Claude
…2900] Assisted-by: Claude
…retainKeys) [RHDHBUGS-2900] Assisted-by: Claude
2 tasks
openshift-cherrypick-robot
temporarily deployed
to
internal
GitHub Actions
Inactive
openshift-cherrypick-robot
temporarily deployed
to
internal
GitHub Actions
Inactive
openshift-cherrypick-robot
temporarily deployed
to
internal
GitHub Actions
Inactive
|
rm3l
approved these changes
May 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #2865 +/- ##
================================================
- Coverage 61.18% 61.05% -0.14%
================================================
Files 37 37
Lines 2128 2108 -20
================================================
- Hits 1302 1287 -15
+ Misses 692 686 -6
- Partials 134 135 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2824
/assign rm3l