Skip to content

fix: remove stale data listener explicitly on socket error #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chrisp1tv wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Open

fix: remove stale data listener explicitly on socket error #3209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd6452
fix: remove stale data listener explicitly on socket error
Chrisp1tv Mar 26, 2026
c6b6288
handle Cursor review
Chrisp1tv Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/client/lib/client/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,13 @@ export default class RedisSocket extends EventEmitter {
#onSocketError(err: Error): void {
const wasReady = this.#isReady;
this.#isReady = false;
const socket = this.#socket;
this.#socket = undefined;
Comment thread
cursor[bot] marked this conversation as resolved.
this.emit('error', err);

socket?.removeAllListeners('data');
socket?.destroy();

if (!wasReady || !this.#isOpen || typeof this.#shouldReconnect(0, err) !== 'number') return;

this.emit('reconnecting');
Expand Down