fix(connect): handle null value sections in connector config validation#2484
Open
isliao613 wants to merge 2 commits into
Open
fix(connect): handle null value sections in connector config validation#2484isliao613 wants to merge 2 commits into
isliao613 wants to merge 2 commits into
Conversation
Kafka Connect may return null for the value section of a connector property when the property is deprecated or inapplicable (e.g. database.out.server.name in Debezium Oracle 3.5.x using LogMiner). - Filter null-value entries in createCustomProperties before mapping; use a type predicate so ConnectorPropertyWithValue narrows correctly downstream (fixes initConfig crash: "Cannot read properties of null (reading 'length')") - Make ConnectorProperty.value, recommended_values and errors nullable in the type to match actual API behaviour - Guard recommended_values and errors with ?? [] in validate() and property-component (fixes validate crash: "Cannot read properties of null (reading 'isEqual')")
Three cases: - initConfig excludes properties whose value section is null - validate() does not crash on null value sections - validate() does not crash on null recommended_values/errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka Connect may return null for the value section of a connector property when the property is deprecated or inapplicable (e.g. database.out.server.name in Debezium Oracle 3.5.x using LogMiner).