Update catch2#34
Closed
mosfet80 wants to merge 8 commits into
Closed
Conversation
Author
|
@ricab Updating the catch library fixes a compilation error in my OpenSuse distro. |
Owner
|
Hi @mosfet80, CI isn't being triggered for some reason (it's been a long time since I looked at this). It might be due to log expiration on earlier commits or something. Would you mind force pushing with new hashes, to see if that wakes it? |
Owner
|
I created #38 to update Linux/macOS CI and I ended up having to update Catch to version 3 in order to avoid a cmake deprecation error. |
Merged
Owner
|
Hi @mosfet80, v3.12.0 is already set in the latest main. Would you mind creating a separate PR with a fresh branch if you mean to update that, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update .github
Update catch2
changelog:
https://github.com/catchorg/Catch2/releases?page=3