Add README.md for berkeley-softfloat-3 library - #1147
Conversation
GitHub did not render README.txt or README.html, so this adds a README.md.
|
I dunno, this seems a little unnecessary and it also means this directory isn't just a straight copy of the upstream code. I guess it doesn't matter too much. |
|
The README.md is actually part of the berkeley-softfloat-3 repository. I recommend that you have a look at https://github.com/riscv/sail-riscv/tree/master/dependencies/softfloat/berkeley-softfloat-3 and see how its rendered now. |
|
Btw. the code that we have right now is not a straight copy. 99% of the code is the same but some files are different including (at least) one folder name that was changed from ( |
|
Ah ok fair enough. I thought I updated it so that it was a whole ago but I must have not actually made that PR. |
Jordan Carlin (jordancarlin)
left a comment
There was a problem hiding this comment.
This is fine for now. Might make more sense to just update the whole directory to get it back in line with upstream (or the Spike version) and bring in the bfloat16 additions.
|
Jordan Carlin (@jordancarlin) Yes, I am working on it |
|
A Spike install creates a |
|
To be honest, I would prefer not to merge the softfloat version from Spike and stick with berkeley-softfloat-3. Its harder to maintain the library otherwise, and we would have to keep track of changes within Spikes codebase. As far as I can tell the berkeley repository has everything we need for now. Its true that Spike has broader support (they even support direct bfloat16 arithmetic for some reason, which the upstream Berkeley version currently does not), but there is no reason Spike couldnt push those changes upstream. In fact, some of the people maintaining Spike also maintain the Berkeley library. |
GitHub did not render README.txt or README.html, so this adds a README.md.