Skip to content

refactor(rlix-validation): remove deprecated no-op assert_partial_overlap_standalone_safe #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TianyeGGBond wants to merge 1 commit into
base: zhenyu/m11-mvp-test
Choose a base branch
from
Open

refactor(rlix-validation): remove deprecated no-op assert_partial_overlap_standalone_safe #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions miles/utils/rlix_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,29 +405,10 @@ def assert_rlix_topology(args: Any, sglang_config: Any | None = None) -> None:
)


def assert_partial_overlap_standalone_safe(args: Any) -> None:
"""Deprecated no-op kept for callsite stability.

Originally intended to refuse partial-overlap topologies under the
standalone entry. Removed because the standalone ``create_placement_groups``
path offsets the rollout pool by ``actor_num_nodes * actor_num_gpus_per_node``,
so zero-based ``train ⊂ infer`` is also true for valid disjoint
standalone configs (e.g. 4 actor GPUs + ``--rollout-num-gpus 8``).
Auto-classifying intent from args alone is unsafe; the env-var guard
(``RLIX_CONTROL_PLANE=rlix``) is the only reliable signal at the standalone
entry. RLix-mode partial-overlap correctness is enforced by
:func:`assert_rlix_topology` (C1) inside the RLix entry driver.
"""
# Intentional no-op — see docstring.
del args
return None


__all__ = [
"is_rlix_mode",
"train_devices_subset_of_infer",
"async_generation_enabled",
"single_updateable_model_and_server",
"assert_rlix_topology",
"assert_partial_overlap_standalone_safe",
]