Skip to content

refactor(rlix): use shared is_rlix_mode() in multi_turn generate #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TianyeGGBond wants to merge 1 commit into
base: zhenyu/m11-mvp-test
Choose a base branch
from
Open

refactor(rlix): use shared is_rlix_mode() in multi_turn generate #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions miles/rollout/generate_hub/multi_turn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"""

import argparse
import os
from copy import deepcopy

from miles.rollout.base_types import (
Expand All @@ -36,13 +35,7 @@
)
from miles.utils.http_utils import post
from miles.utils.misc import load_function


def _is_rlix_mode() -> bool:
"""Mirror miles.utils.rlix_validation.is_rlix_mode without taking the
import dependency (multi_turn must remain importable even when the
rlix_validation module is absent in legacy installations)."""
return os.environ.get("RLIX_CONTROL_PLANE") == "rlix"
from miles.utils.rlix_validation import is_rlix_mode


def _is_scheduler_preempt(output: dict, *, rlix_mode: bool) -> bool:
Expand Down Expand Up @@ -83,7 +76,7 @@ async def generate(input: GenerateFnInput) -> GenerateFnOutput:
# (F29 / C17): radix middleware is off, turn-level redispatch
# requires non-streaming JSON, and partial_rollout has no place in
# either mode.
rlix_mode = _is_rlix_mode()
rlix_mode = is_rlix_mode()
assert not args.partial_rollout, (
"Partial rollout is not supported in multi_turn.generate (F29 / C17)"
)
Expand Down