Skip to content

fix(miles): track pause/continue refs for timeout cancellation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TianyeGGBond wants to merge 1 commit into
base: zhenyu/miles-mvp-e2e
Choose a base branch
from
Open

fix(miles): track pause/continue refs for timeout cancellation #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rlix/pipeline/miles_model_update_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ async def _run_atomic_unit(
# so the subsequent flush_cache returns 200 immediately.
try:
pause_refs = [h.pause_generation.remote(mode="retract") for h in handles.values()]
inflight_refs.extend(pause_refs)
await _ray_get(pause_refs)
except Exception as exc: # noqa: BLE001
logger.warning(
Expand All @@ -313,6 +314,7 @@ async def _run_atomic_unit(
# (4.post) resume the engines so subsequent generate calls work.
try:
cont_refs = [h.continue_generation.remote() for h in handles.values()]
inflight_refs.extend(cont_refs)
await _ray_get(cont_refs)
except Exception as exc: # noqa: BLE001
logger.warning(
Expand Down