Skip to content

gap-ratio: gate demand inflation to the bootstrap window #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TianyeGGBond wants to merge 1 commit into
base: zhenyu/miles-mvp-e2e
Choose a base branch
from
Open

gap-ratio: gate demand inflation to the bootstrap window #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rlix/scheduler/planner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ def _receiver_eligible(state: _GapRatioPipelineState) -> bool:
# Derive remaining from completed metric; same derivation path as
# background rebalance to keep demand semantics consistent.
remaining, step_target = progress_totals_fn(pipeline_id=pipeline_id)
# Capture before the estimate branch overwrites step_target.
in_bootstrap_window = step_target <= 0.0
if step_target <= 0.0:
if has_pending:
raw_estimate = rollout_open_pipelines.get(pipeline_id)
Expand All @@ -210,9 +212,9 @@ def _receiver_eligible(state: _GapRatioPipelineState) -> bool:
else:
percent_remaining = remaining / step_target if step_target > 0 else 0.0

if has_pending:
# Inflate demand in the bootstrap window (request sent, no progress yet)
# so the pipeline gets at least one DP worker allocated before generation starts.
if has_pending and in_bootstrap_window:
# Inflate demand only in the bootstrap window (request sent, no
# progress yet); once progress flows we must not double-count (#36).
remaining += step_target
percent_remaining = remaining / step_target if step_target > 0 else 0.0

Expand Down