WIP: Written content improvements - #57
Draft
therahedwig wants to merge 2 commits into
Draft
Conversation
… and style. Style in particular needs to have more debugging, as I am unsure of the values, but this is a good start.
This now ensures that prose marked as 'great' is using the quality related strings.
therahedwig
force-pushed
the
writtencontent-improvements
branch
from
March 13, 2020 15:09
b4cd937 to
7108b03
Compare
McArcady
reviewed
Mar 13, 2020
| List<String> styleString = new ArrayList<String>(); | ||
| int authorWeight = 50; | ||
|
|
||
| for (String style : styles) { |
Contributor
There was a problem hiding this comment.
Beware, legends_plus (from the dfhack export script) provides its own <style> tags that provoke an exception:
without legends_plus:
<style>vicious:4</style>
<style>serious:2</style>
with legends_plus:
<style>vicious:4</style>
<style>serious:2</style>
<style>Vicious</style>
<style>Serious</style>
The extra tags from legends_plus may have to be ignored for the code to work in all cases ?
McArcady
reviewed
Mar 13, 2020
McArcady
left a comment
McArcady
left a comment
Contributor
There was a problem hiding this comment.
I found a bug, see my comment below
robertjanetzko
force-pushed
the
master
branch
from
October 10, 2020 08:14
8940a30 to
283c3bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently parses the author roll string, and creates functions for the writing quality(which is derived from the author roll) as well as creating a proper style string.
This is pretty WIP, as I need to debug and double check a lot of stuff still. (like, did I collect all the forms that are collections of information, are the values for the style correct, etc.)