Skip to content

fix: return empty int ndarray instead of None for class_id on empty VLM parse #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YousefZahran1 wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −13
Open

fix: return empty int ndarray instead of None for class_id on empty VLM parse #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/supervision/detection/vlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def from_paligemma(
matches = np.array(matches) if matches else np.empty((0, 5))

if matches.shape[0] == 0:
return np.empty((0, 4)), None, np.empty(0, dtype=str)
return np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0, dtype=str)

xyxy, class_name = matches[:, [1, 0, 3, 2]], matches[:, 4]
xyxy = xyxy.astype(int) / 1024 * np.array([w, h, w, h])
Expand Down Expand Up @@ -626,7 +626,7 @@ def from_google_gemini_2_0(
try:
data = json.loads(result)
except json.JSONDecodeError:
return np.empty((0, 4)), None, np.empty((0,), dtype=str)
return np.empty((0, 4)), np.empty((0,), dtype=int), np.empty((0,), dtype=str)

labels = []
xyxy = []
Expand All @@ -640,7 +640,7 @@ def from_google_gemini_2_0(
xyxy.append([box[1], box[0], box[3], box[2]])

if len(xyxy) == 0:
return np.empty((0, 4)), None, np.empty((0,), dtype=str)
return np.empty((0, 4)), np.empty((0,), dtype=int), np.empty((0,), dtype=str)

xyxy = denormalize_boxes(
np.array(xyxy, dtype=np.float64),
Expand Down
20 changes: 10 additions & 10 deletions tests/detection/test_vlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,49 +27,49 @@
"",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # empty text
(
does_not_raise(),
"",
(1000, 1000),
["cat", "dog"],
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # empty text, classes
(
does_not_raise(),
"\n",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # newline only
(
does_not_raise(),
"the quick brown fox jumps over the lazy dog.",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # random text, no location
(
does_not_raise(),
"<loc0256><loc0768><loc0768> cat",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # partial location
(
does_not_raise(),
"<loc0256><loc0256><loc0768><loc0768><loc0768> cat",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # extra loc
(
does_not_raise(),
"<loc0256><loc0256><loc0768><loc0768>",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0).astype(str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0).astype(str)),
), # no class
(
does_not_raise(),
Expand Down Expand Up @@ -436,21 +436,21 @@ def test_from_qwen_2_5_vl(
"random text",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0, dtype=str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0, dtype=str)),
), # random text without JSON format
(
does_not_raise(),
"```json\ninvalid json\n```",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0, dtype=str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0, dtype=str)),
), # invalid JSON within code blocks
(
does_not_raise(),
"```json\n[]\n```",
(1000, 1000),
None,
(np.empty((0, 4)), None, np.empty(0, dtype=str)),
(np.empty((0, 4)), np.empty((0,), dtype=int), np.empty(0, dtype=str)),
), # empty JSON array
(
does_not_raise(),
Expand Down
Loading