fix(release): use pipe delimiter in vendorHash sed commands#657
Merged
Conversation
The vendorHash sed substitutions used `/` as the delimiter, which collided with the `/` characters in base64 sha256 hashes (e.g. `sha256-...u/FnyRh6/...`). On BSD sed this aborts with "bad flag in substitute command: 'F'", leaving flake.nix with an empty vendorHash and a stray flake.nix.bak. Switch to `|` as the delimiter for the three vendorHash substitutions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendorHashsubstitutions inscripts/release.shused/as the sed delimiter, which clashes with the/characters in base64 sha256 hashes. BSD sed (macOS) aborts withbad flag in substitute command: 'F', leavingflake.nixwith an emptyvendorHashand a strayflake.nix.bak.|as the delimiter so slashes in the hash pass through unchanged.🤖 Generated with Claude Code