Require Vector directly instead of through Bvector - #589
Open
andres-erbsen wants to merge 1 commit into
Open
Conversation
1 task
Contributor
|
@mattam82 upstream PR merged, this can be merged at you convenience (doesn't make Coq CI error yet but still fixes a deprecation warning) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am investigating whether we could remove Bvector (vectors of bool) from stdlib. It looks like Equations was needlessly depending on it while only using the polymorphic Vector. I imagine this PR is an improvement regardless of whether Bvector is kept.
Tested with
make && make test-suite.