Bump upper bound to < 9.1 for coq-hammer-tactics - #3472
Conversation
|
@Justme0606 : did you investigate the CI failure? |
Yes sure, i just sending you an email about that. Dear Michael, Regarding this failure, I’m wondering if it might be related to coq-hammer. What do you think about this? Best regards, |
|
Indeed both packages need to be updated. I am not sure if CI will timeout, but since they are related I would suggest to do both updates in one go. Note though that coq-hammer-tactics can be installed without coq-hammer, but if both are installed, they must have the same version. The coq-hammer-tactics without coq-hammer are useful to replay proofs found by coq-hammer on a different machine. |
Ok, thanks for this explanation. That makes sense. |
|
@lukaszcz Installing coq-hammer-tactics.1.3.2+8.20 |
|
@Justme0606 : can you please remove the change to coq-hammer again? After the CI went through we need to discuss with the maintainers what to do about this - to me it looks like a bug in the CI (it requires to build conflicting packages). |
Ok, I rolled back the coq-hammer opam file to version 8.21.~ |
|
@palmskog : can you please have a look at this? IMHO this is a bug in the CI. It insists on compiling coq-hammer because coq-hammer tactics says it is only compatible with specific versions of coq-hammer, but it actually does not require it and the matching versions is not available yet. But coq-hammer-tactics would work. |
|
As explained above it is in my opinion a CI bug that CI fails, so I will go ahead and merge this PR today EOB unless someone complains before. |
|
I don't understand what you mean. The CI did not try to compile And the error seems to be a genuine incompatibility between |
Ok thanks |
|
@silene : sorry for the confusion - there have been a few hence and forth iterations and I was too quick here. The interesting point is that it does work in the Coq Platform CI of @Justme0606 's 9.0 preliminary pick: https://github.com/rocq-prover/platform/actions/runs/16447168506/job/46482201062?pr=476#step:5:963 and I also have seen it working locally and I believe I have seen previous CI runs of this PR where trying to install coq-hammer itself was the issue. I will investigate this deeper together with @Justme0606 |
|
Does the platform run the package tests? Because the failure seemingly occurs in a test here. |
|
@silene : thanks a very good point! Indeed Coq Platform CI does not install with @Justme0606 : can you please check if only one specific test fails (by installing coq-hammer-tactics and going through the test file(s) in an IDE) or if coq-hammer-tactics fails frequently ... always. |
|
The assertion seems related to a misuse of the evarmap: |
|
Thanks Michael. |
|
I haven't tried to run CoqHammer with Rocq 9.x yet. I'll look into it and
try to sort out possible incompatibilities, but probably won't have much
time for it before the middle of August, if more changes are needed.
…On Wed, 23 Jul 2025, 11:42 Enrico Tassi, ***@***.***> wrote:
*gares* left a comment (rocq-prover/opam#3472)
<#3472 (comment)>
The assertion seems related to a misuse of the evarmap:
https://github.com/rocq-prover/rocq/blob/455ab6b39a73261b6dddcf914faed68af90d02ec/pretyping/evarsolve.ml#L912C5-L914
And it does not always fail since
https://github.com/lukaszcz/coqhammer/blob/fc88e83aba295cffd415fa601ff78847e522aad7/tests/tactics/tactics_test.v#L493
it is not the first occurrence of hauto.
—
Reply to this email directly, view it on GitHub
<#3472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPKH5IVANHX4EAVKS2NSL3J5KIJAVCNFSM6AAAAACB7PW7ESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBWG42DENRSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
A hack solution would be to comment out whichever lemmas in the CoqHammer
tactics test file are causing problems.
…On Wed, 23 Jul 2025, 11:59 Łukasz Czajka, ***@***.***> wrote:
I haven't tried to run CoqHammer with Rocq 9.x yet. I'll look into it and
try to sort out possible incompatibilities, but probably won't have much
time for it before the middle of August, if more changes are needed.
On Wed, 23 Jul 2025, 11:42 Enrico Tassi, ***@***.***> wrote:
> *gares* left a comment (rocq-prover/opam#3472)
> <#3472 (comment)>
>
> The assertion seems related to a misuse of the evarmap:
>
> https://github.com/rocq-prover/rocq/blob/455ab6b39a73261b6dddcf914faed68af90d02ec/pretyping/evarsolve.ml#L912C5-L914
> And it does not always fail since
>
> https://github.com/lukaszcz/coqhammer/blob/fc88e83aba295cffd415fa601ff78847e522aad7/tests/tactics/tactics_test.v#L493
> it is not the first occurrence of hauto.
>
> —
> Reply to this email directly, view it on GitHub
> <#3472 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAPKH5IVANHX4EAVKS2NSL3J5KIJAVCNFSM6AAAAACB7PW7ESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBWG42DENRSGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@Justme0606 : yes. In general I prefer to include as many packages as possible in the preview, so that potential other issues can be found. But if if it will likely fall apart for every user, it would be better to not include it, because every user would fall into the issues we already know so that we wouldn't learn anything new from including it. We need to do some guess work on the odds. |
|
possibly related fix rocq-prover/rocq#20960 |
|
I have updated CoqHammer to work with Rocq 9.0: #3526 |
This PR adds an upper bound < "9.1.0" to the coq dependency for the following package(s):
This is required for compatibility with Rocq 9.0 and was tested successfully as part of the Rocq Platform 9.0 release preparation.
/cc @MSoegtropIMC