Add missing analysis dependency to experimental reals dev package - #3789
Merged
JasonGross merged 1 commit intoAug 6, 2026
Merged
Conversation
This was referenced Jul 30, 2026
JasonGross
force-pushed
the
codex/experimental-reals-analysis-dep
branch
from
July 31, 2026 19:22
d49d3bc to
18f881f
Compare
JasonGross
force-pushed
the
codex/experimental-reals-analysis-dep
branch
from
July 31, 2026 19:45
18f881f to
885f2e6
Compare
JasonGross
marked this pull request as ready for review
August 6, 2026 04:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development version of
coq-mathcomp-experimental-realsnow importsmathcomp.esum,mathcomp.ereal, andmathcomp.numfun. Those modules live in thecoq-mathcomp-analysispackage, but the opam metadata did not declare that dependency, allowing the experimental-reals build to start before analysis was available.Add the matching-version analysis dependency so opam orders these builds correctly.
Validation:
opam lintpasses for the updated package. The observed build failure wasUnable to locate library esum with prefix mathcomp; the analysis development package was concurrently still building, confirming the missing dependency edge. Full source validation will follow once that long-running dependency build completes.CI note. Rebased onto master. The
opam-build:4.09.0failure this PR was showing wasrocq-runtime.9.3.devdying at./configurewith "You need OCaml 4.14.0 or later"; that is fixed in master by #3803, so the rebase clears it. An earlier revision of this branch also carried adune < 3.24bound forrocq-elpi.devandrocq-micromega-plugin.dev; that has been split out into #3806 so this PR is the one-line dependency fix only.Update (rebased again). #3806 has merged, so the elpi/micromega
dune < 3.24bound is now in master. This branch is rebased on top of it; theopam-build:4.14.2and5.3.0failures were mathcomp-analysis pulling inrocq-elpi.dev, so they should clear too.