Abstract discharge functions over how names are themselves discharged - #18062
Closed
herbelin wants to merge 2 commits into
Closed
Abstract discharge functions over how names are themselves discharged#18062herbelin wants to merge 2 commits into
herbelin wants to merge 2 commits into
Conversation
herbelin
added
kind: cleanup
coqbot-app
Bot
added
the
needs: full CI
This was referenced Sep 19, 2023
Closed
Member
Author
|
@coqbot run full ci |
coqbot-app
Bot
removed
the
needs: full CI
github-actions
Bot
added
the
needs: rebase
Contributor
|
The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed. |
That means canonically relying on discharge functions for global references.
herbelin
force-pushed
the
master+principled-discharge
branch
from
December 8, 2023 11:57
aa31d18 to
f897a3f
Compare
coqbot-app
Bot
added
needs: full CI
github-actions
Bot
added
the
needs: rebase
Contributor
|
The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed. |
Contributor
|
This PR was not rebased after 30 days despite the warning, it is now closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preliminatory work for discharge on the fly (extracted from #17888): we anticipate that a kernel name might include an information about the section where it is defined and that discharging such name may need to update this information.
In passing, this abstracts over all instances of the
isVarRef r && Lib.is_in_section ridioms of discharge functions.