Skip to content

Remove dynamic scheme generation - #22192

Open
SkySkimmer wants to merge 3 commits into
rocq-prover:masterfrom
SkySkimmer:noforce-scheme
Open

Remove dynamic scheme generation#22192
SkySkimmer wants to merge 3 commits into
rocq-prover:masterfrom
SkySkimmer:noforce-scheme

Conversation

@SkySkimmer

Copy link
Copy Markdown
Contributor

No description provided.

@SkySkimmer
SkySkimmer requested review from a team as code owners June 30, 2026 11:46
@SkySkimmer SkySkimmer added the kind: cleanup Code removal, deprecation, refactorings, etc. label Jun 30, 2026
@coqbot-app coqbot-app Bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jun 30, 2026
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jun 30, 2026
@coqbot-app coqbot-app Bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jun 30, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor Author

@JasonGross @Janno @Alizter @jdchristensen @RalfJung @robbertkrebbers @gares @proux01
@benediktahrens @m-lindgren @nmvdw @rmatthes @mattam82 @yforster
please ensure your developments compile with warning missing-scheme set as error

@proux01

proux01 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@SkySkimmer for oddorder, I tried this math-comp/odd-order#84 which works well on this PR but fails on 9.1: math-comp/odd-order#84 What am I expected to do ? At worst I'm fine droping 9.1 support but Rocq compat policy is "compatibility with two successive versions" so I'd expect a solution working for both 9.1 and 9.2.

@SkySkimmer

Copy link
Copy Markdown
Contributor Author

Maybe it's too early to remove this then

@RalfJung

RalfJung commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

please ensure your developments compile with warning missing-scheme set as error

When I tried this around the 9.2 release, it was impossible because the new commands we have to use do not exist in Rocq 9.1. So, basically what @proux01 said -- I think this needs to wait a cycle.

@proux01

proux01 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

So, let's complete this just after 9.3.0 is out I guess.

@RalfJung

Copy link
Copy Markdown
Contributor

(Also FWIW the error messages this generates are pretty hard to interpret. It talks about Missing "rew_r" scheme, which apparently is related to Scheme Rewriting, but I have no idea how I am supposed to figure that out. I was not even able to find a list of valid schemes in the docs and there are no search results for rew_r.)

@SkySkimmer

Copy link
Copy Markdown
Contributor Author

You can figure it out because the error tells you to use Scheme Rewriting.

@RalfJung

Copy link
Copy Markdown
Contributor

Hm, in the CI log here I only see

File "./iris/bi/sbi_unfold.v", line 281, characters 7-21:
Error:
Missing "rew_r" scheme for TCEq.

@SkySkimmer

Copy link
Copy Markdown
Contributor Author

You're looking at the error summary, it only contains the first line of the error. Also it's not guaranteed to be complete.

@RalfJung

Copy link
Copy Markdown
Contributor

Ah right, locally I get more context. A bit unfortunate that CI swallows that, but maybe us project maintainers are not expected to look at that output.^^

@SkySkimmer

Copy link
Copy Markdown
Contributor Author

The CI doesn't swallow it, just look back up in the log https://gitlab.inria.fr/coq/coq/-/jobs/7531633#L7658

@SkySkimmer SkySkimmer added the needs: coq release Should not be merged until the next version has been branched (see milestone). label Jul 2, 2026
@SkySkimmer SkySkimmer added this to the 9.4+rc1 milestone Jul 2, 2026
@@ -0,0 +1,4 @@
- **Removed:**
automatic scheme generation by :tacn:`rewrite`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the changelog get a description of adjustment that is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc. needs: coq release Should not be merged until the next version has been branched (see milestone).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants