Remove dynamic scheme generation - #22192
Conversation
|
@JasonGross @Janno @Alizter @jdchristensen @RalfJung @robbertkrebbers @gares @proux01 |
|
@SkySkimmer for oddorder, I tried this math-comp/odd-order#84 which works well on this PR but fails on 9.1: math-comp/odd-order#84 What am I expected to do ? At worst I'm fine droping 9.1 support but Rocq compat policy is "compatibility with two successive versions" so I'd expect a solution working for both 9.1 and 9.2. |
|
Maybe it's too early to remove this then |
When I tried this around the 9.2 release, it was impossible because the new commands we have to use do not exist in Rocq 9.1. So, basically what @proux01 said -- I think this needs to wait a cycle. |
|
So, let's complete this just after 9.3.0 is out I guess. |
|
(Also FWIW the error messages this generates are pretty hard to interpret. It talks about |
|
You can figure it out because the error tells you to use Scheme Rewriting. |
|
Hm, in the CI log here I only see |
|
You're looking at the error summary, it only contains the first line of the error. Also it's not guaranteed to be complete. |
|
Ah right, locally I get more context. A bit unfortunate that CI swallows that, but maybe us project maintainers are not expected to look at that output.^^ |
|
The CI doesn't swallow it, just look back up in the log https://gitlab.inria.fr/coq/coq/-/jobs/7531633#L7658 |
| @@ -0,0 +1,4 @@ | |||
| - **Removed:** | |||
| automatic scheme generation by :tacn:`rewrite` | |||
There was a problem hiding this comment.
Can the changelog get a description of adjustment that is needed?
No description provided.