Added initial typehints #494
Open
Claude / Claude Code Review
completed
May 16, 2026 in 20m 5s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | pyproject.toml:47-53 |
Missing 'packaging' in test dependency group |
| 🟡 Nit | rollbar/lib/traverse.py:176-179 |
Dead **custom_handlers branch in traverse() |
Annotations
Check warning on line 53 in pyproject.toml
claude / Claude Code Review
Missing 'packaging' in test dependency group
Test file `rollbar/test/fastapi_tests/test_routing.py:6` directly imports `from packaging.version import Version` (new in this PR for the version comparison fix), but `packaging` is not declared in the `test` dependency group in `pyproject.toml`. This currently works only transitively because pytest declares `packaging>=22` as a runtime requirement; declaring direct imports as direct deps is the same hygiene the PR already applied for `typing_extensions` (added to runtime deps because the PR new
Check warning on line 179 in rollbar/lib/traverse.py
claude / Claude Code Review
Dead **custom_handlers branch in traverse()
Minor: the new defensive gate at `traverse.py:176-179` (`isinstance(handler_type, (type, tuple)) and isinstance(obj, handler_type)`) is unreachable. `**custom_handlers` collects kwargs into a dict whose keys Python guarantees to be `str` (passing a non-string key raises `TypeError: keywords must be strings` at call time), so `isinstance(handler_type, (type, tuple))` is provably always False. No caller in `rollbar/` or tests populates this slot today, so there is zero runtime impact — but the gat
Loading