Skip to content

✨ Optimize batch path watching via Watcher::paths_mut #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roma-glushko merged 2 commits into from
Mar 9, 2026
Merged

✨ Optimize batch path watching via Watcher::paths_mut #53

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ea326
[CRW] Use paths_mut() for adding many paths at once
c-h-russell-walker Mar 9, 2026
540a27e
Add error handling to commit() call
c-h-russell-walker Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/watcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ impl Watcher {
RecursiveMode::NonRecursive
};

let mut watcher_paths = self.inner.paths_mut();
for p in paths {
let path = PathBuf::from(&p);

Expand All @@ -99,7 +100,7 @@ impl Watcher {
)));
}

let result = self.inner.watch(&path, mode);
let result = watcher_paths.add(Path::new(&p), mode);

if let Err(err) = result {
if !ignore_perm {
Expand All @@ -110,6 +111,8 @@ impl Watcher {
// self.file_cache.add_root(path, mode);
}

watcher_paths.commit().ok();
Comment thread
c-h-russell-walker marked this conversation as resolved.
Outdated

if self.debug {
println!("watcher: {:?}", self.inner);
}
Expand Down