[ntuple] Add kTypeS3 locator type for S3 storage backend#22351
Open
JasMehta08 wants to merge 3 commits into
Open
[ntuple] Add kTypeS3 locator type for S3 storage backend#22351JasMehta08 wants to merge 3 commits into
JasMehta08 wants to merge 3 commits into
Conversation
Test Results 22 files 22 suites 3d 14h 12m 8s ⏱️ For more details on these failures, see this check. Results for commit a61c365. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request
(Is a part of the GSoC 2026 project
S3 Backend for RNTuple.)The S3 backend supports two addressing modes: Mode A packs multiple pages into a single S3 object and uses a new locator type to encode both the object ID and byte offset, while Mode B stores one page per object and reuses the existing Object64 locator. This PR adds the on-disk format support needed for Mode A.
This PR:
kTypeS3 = 0x03to theELocatorTypeenum inRNTupleTypes.hxxSerializeLocator()andDeserializeLocator()inRNTupleSerialize.cxx, reusing the existingSerializeLocatorPayloadObject64/DeserializeLocatorPayloadObject64The 64-bit payload is interpreted differently depending on the locator type:
0x03(Mode A) bit-splices upper 32 bits as object ID and lower 32 bits as byte offset, while0x02(Mode B) uses the full value as a plain object ID. The interpretation is handled by the backend, not the serializer. The serializer just stores and retrieves the raw 64-bit value.Checklist
kTypeS3(0x03) andkTypeDAOS(0x02), locally.