camera_calibration_parsers: allow reading read-only INI files - #431
Open
ktyang512 wants to merge 1 commit into
Open
camera_calibration_parsers: allow reading read-only INI files#431ktyang512 wants to merge 1 commit into
ktyang512 wants to merge 1 commit into
Conversation
Open calibration INI files with std::ifstream so read access does not require write permission. Add cross-platform regression coverage for read-only files. Generated-by: OpenAI Codex (GPT-5) Signed-off-by: ktyang512 <ktyang512@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::ifstreamso reading does not require write permissionFixes #397.
Testing
std::fstreamimplementationcamera_calibration_parsers-parse_ini: 7 tests passed, including the read-only regression under an ordinary Linux userament_uncrustifyandament_cpplintpassed for both changed filesgit diff --checkpassedThe read-only test performs a capability probe and skips when the test process can still open the file read/write, such as a privileged root container. The regression executed without skipping under the host ordinary user. Native Windows and macOS execution are left to CI.
Generative tool disclosure
Generated-by: OpenAI Codex (GPT-5)