Allow to bridge between ROS_LOCALHOST=0 and ROS_LOCALHOST=1 - #78
Open
cyrilleberger wants to merge 1 commit into
Open
Allow to bridge between ROS_LOCALHOST=0 and ROS_LOCALHOST=1#78cyrilleberger wants to merge 1 commit into
cyrilleberger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes started with ROS_LOCALHOST=0 cannot communicate directly with nodes started with ROS_LOCALHOST=1 (at least with fastdds). With this change we can now specify the localhost mode for the "from" and "to". This allow to use ROS_LOCALHOST=0 to keep topic private, and selectively export the topic.
This was done by adding two new keys to yaml
from_local_host_only/to_local_host_only, which can take "default", "enabled" and "disabled", mimicking the values inrmw_localhost_only_e.The following configuration was used to forward the chatter topic from a localhost only talker to the general world:
Can be tested by starting: