Add setter and getter for domain_id in rcl_init_options_t (backport #678) - #946
Merged
Conversation
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 45f1331)
Member
|
This backport is needed to implement the discussion in ros2/domain_bridge#60 (comment). CC: @jacobperron |
fujitatomoya
approved these changes
Nov 2, 2021
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm once DCO is addressed.
jacobperron
approved these changes
Nov 2, 2021
Member
|
CI up to rcl (since this is adding new functionality):
|
Member
|
Not sure what to make of the macOS test failures, since there's no consumer of the added functions yet. These tests have been reported as flaky in #750. |
3 tasks
Member
|
Yes, the tests are failing because there's a vestigial ros2cli daemon node running on the macOS host. I think we can safely ignore those errors. Also, the Windows CMake warnings are pre-existing. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #678 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/