Skip to content

Fix process exit crash in Clang builds by using RTLD_NODELETE for shared libraries #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbrameld wants to merge 1 commit into
base: rolling
Choose a base branch
from
+4 −1
Open

Fix process exit crash in Clang builds by using RTLD_NODELETE for shared libraries #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/shared_library.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ rcutils_load_shared_library(
// for further reference.

#ifndef _WIN32
lib->lib_pointer = dlopen(library_path, RTLD_LAZY);
// RTLD_NODELETE: don't unmap on dlclose. Heap-resident references into the
// library (e.g. shared_ptr/weak_ptr control-block vtables) can outlive the
// dlopen/dlclose cycle; unmapping would dangle them.
lib->lib_pointer = dlopen(library_path, RTLD_LAZY | RTLD_NODELETE);
if (NULL == lib->lib_pointer) {
RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING("dlopen error: %s", dlerror());
return RCUTILS_RET_ERROR;
Expand Down