Fix date_time_with_ms millisecond formatting#570
Open
ahuazuipiaoliang wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mark Jin <mark@pixmoving.net>
fujitatomoya
approved these changes
May 28, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
good eye! thanks for the PR.
this is real bug. any timestamp whose subsecond portion is under 100 ms produced wrong output, which is a substantial fraction of timestamps in practice.
Collaborator
|
Pulls: #570
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
{date_time_with_ms}formatting so the subsecond field is computed as milliseconds instead of taking the first three digits from an unpadded nanosecond string.Details
The previous implementation converted the nanosecond remainder to a decimal string without zero-padding and then used the first three characters. For values with leading zeros, such as
085860000 ns, this produced.858instead of.085.This PR computes milliseconds directly with
nanoseconds / 1000000and formats the value with%03.Testing
Added coverage for a timestamp whose nanosecond remainder has leading zeros.
Closes #569