:farmer: warning deprecated register storage class specifier from custom_sql_filter.cpp

[miguelgonrod]

System Info

• Windows 11
• Rolling

Bug Description

A warning is showing in buildfarm nightly windows by a deprecation in register keyword

Expected Behavior

Build without warnings

How to Reproduce

1. Go to https://ci.ros2.org/job/nightly_win_rel
2. Build a job
3. See the warning

Additional context

Reference Build

• https://ci.ros2.org/job/nightly_win_rel/3836

Log Output

custom_sql_filter.cpp

C:\ci\ws\src\ros2\rmw_connextdds\rmw_connextdds_common\src\ndds\custom_sql_filter.cpp(343,3): warning C5033: 'register' is no longer a supported storage class [C:\ci\ws\build\rmw_connextdds_common\rmw_connextdds_common_pro.vcxproj]

     Creating library C:/ci/ws/build/rmw_connextdds_common/Release/rmw_connextdds_common_pro.lib and object C:/ci/ws/build/rmw_connextdds_common/Release/rmw_connextdds_common_pro.exp

  rmw_connextdds_common_pro.vcxproj -> C:\ci\ws\build\rmw_connextdds_common\Release\rmw_connextdds_common_pro.dll

Looking at internet, register keyword got deprecated on C++14 https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0001r1

[fgallegosalido]

Hi @miguelgonrod, thank you for reporting this issue! This warning is caused by the macro REDASkiplist_findNode, which internally makes use of the keyword register multiple times.

To fix this issue, we would need to avoid calling that macro, but that would require changing the implementation of the custom SQL filter.

[miguelgonrod]

ohhhhhh thanks for that context, so it is the best to just silence the warning? or should we take the SQL filter update approach?

[fgallegosalido]

As the keyword is deprecated, we should aim to remove the warning by not using that macro. However, that change is significant and may even affect performance or concurrency if not done carefully. We will discuss this internally and I will let you know on what we decide.