change rmw_implementation deps to be buildtool and not exec - #99
Conversation
|
Can you reorder these two new lines to follow the schema order ? |
|
How do you mean? I think they are in that order? Do you mean move them above the lines around them? This package already has a mixture of depend and other tags, so I didn't try to reorder everything. |
|
@wjwwood What is the status on this? |
|
Sorry, this fell through the cracks. When you poked me originally, I hesitated to merge it now because I was worried it shouldn't go into foxy. But I can merge it and then decide if we should back port it. Any thoughts on if it should be back ported? |
|
From a Debian point of view this is a no-op and (to my knowledge) we nowhere use these dependency types differently anywhere else. Therefore I don't mind if it does get backported or not. |
|
@ahcorde can you re-review this? |
5ded3c5 to
e4a6d18
Compare
|
Pulls: #99 |
|
Tick the box to add this pull request to the merge queue (same as
|
|
@asymingt I think it still makes sense. I rebased, tested it locally (looks good), and triggered CI. Let's see what it does. |
Signed-off-by: William Woodall <wjwwood@google.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
e4a6d18 to
da04d02
Compare
|
Pulls: #99 |
Discovered this while going over dependencies again with @chapulina. I think it should be build tool and not exec.