fix: Fix lock order inversion / deadlock - #1010
Merged
Merged
Conversation
This fixes a deadlock if a guard condition was triggered while a guard condition was being attached or detached. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Author
|
Pulls: #1010
|
Yadunund
approved these changes
Jul 17, 2026
Contributor
Author
|
@Mergifyio backport kilted jazzy humble |
✅ Backports have been createdDetails
|
This was referenced Jul 20, 2026
ahcorde
pushed a commit
that referenced
this pull request
Jul 20, 2026
(cherry picked from commit c5c101a) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
ahcorde
pushed a commit
that referenced
this pull request
Jul 20, 2026
This fixes a deadlock if a guard condition was triggered while a guard condition was being attached or detached. (cherry picked from commit c5c101a) Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
ahcorde
added a commit
that referenced
this pull request
Jul 20, 2026
* fix: Fix lock order inversion / deadlock (#1010) This fixes a deadlock if a guard condition was triggered while a guard condition was being attached or detached. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> (cherry picked from commit c5c101a) * make linters happy Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> --------- Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Janosch Machowinski <jmachowinski@users.noreply.github.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
doisyg
pushed a commit
to botsandus/rmw_zenoh
that referenced
this pull request
Aug 9, 2026
This fixes a deadlock if a guard condition was triggered while a guard condition was being attached or detached. Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com> Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lyrical backport of #1005