Use the SPDX identifier Apache-2.0 in license declarations - #397
Merged
Merged
Conversation
The <license> tags in package.xml and the license= fields in setup.py
spelled the license as prose ("Apache License 2.0", "Apache License,
Version 2.0", "Apache 2.0"). Use the SPDX identifier instead so the
declaration can be matched mechanically. The license itself does not
change.
Assisted-by: Claude Code:claude-opus-5 [git, gh]
Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rolling #397 +/- ##
========================================
Coverage 88.18% 88.18%
========================================
Files 18 18
Lines 601 601
Branches 53 53
========================================
Hits 530 530
Misses 52 52
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
asymingt
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spells the license as its SPDX identifier:
Apache-2.0inpackage.xml<license>tags andsetup.pylicense=fields (3 files). Text only -- the license itself is unchanged, and nothing else is touched.One of ~60 mechanical PRs across the ROS 2 core so license declarations can be checked automatically. Same change as ament/ament_package#168.
Did you use Generative AI?
Yes. Assisted-by: Claude Code:claude-opus-5 [git, gh]