Skip to content

Remove unused main args from test nodes - #399

Merged
sloretz merged 1 commit into
ros2:rollingfrom
dancher00:fix-unused-main-args
Sep 29, 2026
Merged

sloretz merged 1 commit into
ros2:rollingfrom
dancher00:fix-unused-main-args

Conversation

@dancher00

Copy link
Copy Markdown
Contributor

Fixes #398.

Removes the unused args parameter from both fixture entry points and initializes rclpy without forwarding it.

Tested with compileall. The ROS-specific lint tests could not run locally because the ament_flake8 and ament_pep257 packages are not installed.

Signed-off-by: dancher00 <dancher.00@gmail.com>
@fujitatomoya

Copy link
Copy Markdown

Pulls: #399
Gist: https://gist.githubusercontent.com/fujitatomoya/dc2c70255d1f13d6c4f63b10391c0e9a/raw/077e85bcb37e3c84711464a3d7c8230a91aada88/ros2.repos
BUILD args: --packages-up-to sros2
TEST args: --packages-select sros2
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20550

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz

sloretz commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Thank you for the PR!

I see one test failure on Windows, but I think that's a known flaky test. Merging.

@sloretz
sloretz merged commit 17c9efa into ros2:rolling Sep 29, 2026
4 checks passed
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (51cedf6) to head (49c989d).
⚠️ Report is 2 commits behind head on rolling.

Additional details and impacted files
@@           Coverage Diff            @@
##           rolling     #399   +/-   ##
========================================
  Coverage    88.18%   88.18%           
========================================
  Files           18       18           
  Lines          601      601           
  Branches        53       53           
========================================
  Hits           530      530           
  Misses          52       52           
  Partials        19       19           
Flag Coverage Δ
unittests 88.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete unused args argument from main() in Python files

3 participants