Repository navigation
feat(oauth): return saved credential IDs from v8 login status - #168
Open
JustYannicc wants to merge 2 commits into
Open
JustYannicc wants to merge 2 commits into
JustYannicc wants to merge 2 commits into
Conversation
2 tasks
Author
|
The pr-test-build run ended with The cluster and management tests and Home build pass locally at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home returns only
{"status":"ok"}after OAuth login, so management clients must diff the credential list to identify what was saved.GET /v8/management/oauth/status?state=...now returnsauth_idfor a single credential andauth_idsfor all credentials saved by the session.The result is stored atomically with the credentials and remains readable from other Home nodes for the existing one-minute completion TTL. Pending session secrets are cleared. Plugin completion uses the same response, including its first successful poll. The v0 response stays unchanged. English and Chinese Management API docs are updated.
Example for a single-credential login:
{"status":"ok","auth_id":"credential-uuid","auth_ids":["credential-uuid"]}Validation with Go 1.27.3:
go test -p 2 ./internal/cluster/... ./internal/managementhttp -count=1passes.go build -o test-output ./cmd/homepasses.No live provider login or PostgreSQL deployment was tested.