Repository navigation
fix(weather): VRB wind with a gust takes the gust as worst-case crosswind - #36
Merged
Merged
Conversation
…wind A variable wind has no direction, so its gust can come from abeam just as the mean wind can. wind_components gave VRB05G20 a max_crosswind of 5; it is now 20. Directional winds are unchanged. Found while building the runway + wind widget in flyfun-weather (roznet/flyfun-weather#758), which shows max_crosswind for VRB winds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QCbHFQiRxP8H8J4NPqz2AB
Merged
4 tasks
Code ReviewReviewed the VRB-with-gust change to Important
Minor
|
roznet
added a commit
that referenced
this pull request
Oct 11, 2026
within_limits() read gust_crosswind (None for VRB) or the mean-direction crosswind, so VRB05G20 reported max_crosswind=20 yet passed a 15 kt limit. It now also checks max_crosswind, which covers VRB gusts and variable sectors (270V240-300 on runway 27 checks 7.5 kt, not 0). Design doc notes that VRB leaves gust_crosswind as None. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
WeatherAnalyzer.wind_componentsgave a variable wind with no direction amax_crosswindequal to its mean speed, ignoring the gust:VRB05G20reported a worst case of 5 kt. With no direction, the gust can come from abeam as easily as the mean wind, so the worst case is now the gust (20). Directional winds are unchanged.Found while building the runway + wind widget in roznet/flyfun-weather#758, which shows
max_crosswindfor VRB winds. The flyfun-weather side does not depend on this fix: it builds aWeatherReportand calls the existing API, so it works on 0.21.0 and picks this up once released and the pin moves.Library vs app: this is the only change that belongs in euro_aip. The issue's optional free function
wind_components(dir, speed, gust, …)was not added, because building a minimalWeatherReportalready covers it, and adding it would force a release before the app could ship. The picture model, the advisory tiers and the drawing rules are app-specific and stay in flyfun-weather.designs/briefing_weather.mdupdated (worst-case row and edge-case note)./releasedoes that.Testing
pytest tests/briefing/test_weather -q: 326 passed, including the newtest_variable_wind_no_direction_with_gust.🤖 Generated with Claude Code
https://claude.ai/code/session_01QCbHFQiRxP8H8J4NPqz2AB
Generated by Claude Code