Skip to content

fix 4.7 return type error in _get_rid() #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebuddyadrian wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix 4.7 return type error in _get_rid() #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/controller_icons/objects/ControllerIconTexture.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,9 @@ func _get_rid():
# This results in a one-frame white texture being displayed, which is not ideal. Investigate later.
_stitch_texture()
if _is_stitching_texture:
return 0
return RID()
else:
return 0
return RID()
return _texture_3d.get_rid() if not _textures.is_empty() else 0

@rsubtil rsubtil Jun 20, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing this spot:

Suggested change
return _texture_3d.get_rid() if not _textures.is_empty() else 0
return _texture_3d.get_rid() if not _textures.is_empty() else RID()


#endregion