fix(filters): use tail_lines for just/mise/task to preserve failure summaries (#1065)#2481
Open
ousamabenyounes wants to merge 2 commits into
Open
fix(filters): use tail_lines for just/mise/task to preserve failure summaries (#1065)#2481ousamabenyounes wants to merge 2 commits into
ousamabenyounes wants to merge 2 commits into
Conversation
max_lines = 50 was truncating verbose wrapped-tool output (pytest, cargo test) from the front, hiding failure summaries that appear at the end. Replace with tail_lines = 200 so the last 200 lines of output — where failures are reported — are always visible. Closes rtk-ai#1065 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…l_lines Address @YOMXXX review on rtk-ai#1191. Prior fixture (~9 lines) did not exceed the old `max_lines = 50` cap, so the test passed even under the regressed behavior. New fixtures use 58 progress lines + 3-line failure summary at the tail (61 total). Verified locally: temporarily reverting `tail_lines = 200` back to `max_lines = 50` makes all three tests FAIL (summary truncated at line 50), restoring the new setting makes them PASS — proving the assertion actually protects the change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1065.
The
just,miseandtaskTOML delegator filters usedmax_lines = 50, which truncated wrapped tool output at 50 lines. When the wrapped command printed more than that, the pass/fail summary at the tail (e.g.FAILED: test_x,result: N failures) was dropped — hiding test failures.Fix
Replace
max_lines = 50withtail_lines = 200in all three filters so the end of the output (where test runners print their summary) is always preserved. Adds an inline[[tests.<filter>]]regression case per filter (input deliberately exceeds the old 50-line cap and ends with a failure summary).Test verification (RED → GREEN)
Run via
rtk verify --filter <name>(the project's TOML inline-test runner).RED — config reverted to
max_lines = 50:GREEN — with
tail_lines = 200:(Re-proposes the accidentally-closed #1191, rebased onto current
develop.)