fix(api): update token expiration format to include milliseconds#1821
Open
pg-nanjum wants to merge 1 commit into
Open
fix(api): update token expiration format to include milliseconds#1821pg-nanjum wants to merge 1 commit into
pg-nanjum wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `expiration` field in the Token API endpoints currently shows timestamps without milliseconds in the docs (e.g. `2017-03-25T21:16:50Z`). The actual API response now includes milliseconds (e.g. `2017-03-25T21:16:50.403Z`), causing customer automation scripts that do strict timestamp parsing to break.
Verification
Verified against a live RBA staging environment:
Changes
Updated 7 `expiration` field examples across 3 sections in `docs/api/index.md`:
Format corrected: `YYYY-MM-DDTHH:MM:SSZ` → `YYYY-MM-DDTHH:MM:SS.mmmZ`
Note: `expirationDate` fields in other API sections were intentionally left unchanged as they are unrelated to token management.
Root Cause Analysis
This is an unintentional side effect of the Grails 7 migration — not a deliberate API change.
The field in question is `rundeckapp/src/main/groovy/com/dtolabs/rundeck/app/api/tokens/Token.groovy`:
A permanent fix would be to pin the format explicitly:
This would restore the previous no-milliseconds format. Alternatively, the current millisecond-inclusive format can be accepted as correct going forward — which is what this doc PR does.
🤖 Generated with Claude Code