Add context guide, skill files and dev scripts - #1132
Merged
Conversation
anvacaru
marked this pull request as ready for review
April 24, 2026 07:23
juliankuners
previously requested changes
Apr 25, 2026
Co-authored-by: Julian Kuners <julian.kuners@gmail.com>
Co-authored-by: Julian Kuners <julian.kuners@gmail.com>
Under `set -e`, `root=$(git rev-parse --show-toplevel)` exits the script on failure before `if [ $? -eq 0 ]` is ever evaluated, so the "not inside a Git repository" branch was dead code. Move the failing command into the `if` condition (which exempts it from `set -e`) and `exit 1` on failure so the build never proceeds outside a repository. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a skill for authoring and validating K simplification lemmas when `kontrol prove` leaves pending/stuck KCFG leaves. Ships the runLemma/doneLemma scaffolding, a kompile+prove wrapper, a stuck-term extractor, and a lemma-set minimizer, plus supporting docs on flag-level fixes, soundness testing, minimization, and lessons learned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
palinatolmach
self-requested a review
August 7, 2026 12:31
palinatolmach
dismissed
juliankuners’s stale review
August 7, 2026 14:05
Most issues were fixed, the rest will be addressed in a follow up.
palinatolmach
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Claude Code support for the Kontrol repo: a context guide for navigating the codebase, three workflow skills, and two developer scripts.
CLAUDE.md/AGENTS.md: guide covering project structure, K semantic definitions, CLI commands, cheatcode inventory (Foundry and Kontrol-proprietary), testing conventions, dev workflow, and gotchas.
Skills
/build- runsscripts/build-kontrol, captures output, surfaces K compiler errors on failure/add-cheatcode- step-by-step guide for adding a new cheatcode (K rule, selector, Solidity test, CI registration)/update-expected-output— runs golden file regeneration for foundry / CSE+minimize / end-to-end suites; recommends scoping with--foundry/--cse/--end-to-endand-k test_name/writing-kontrol-lemmas— helps generate K lemmas to facilitate proof execution. To be used in downstream projects.Scripts
scripts/build-kontrol— K version check/install,uv sync,kdist clean+buildscripts/selector— computes ABI function selector as decimal integer (wrapscast sig)scripts/update-expected-output— pytest.expectedfile regeneration with per-suite flags and parallel worker tuning