Skip to content

Fix GUI tests#3131

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-gui-tests
Open

Fix GUI tests#3131
GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-gui-tests

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Jun 1, 2026
@GuillaumeGomez GuillaumeGomez force-pushed the fix-gui-tests branch 4 times, most recently from 313b49d to 3456c9b Compare June 1, 2026 13:43
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Fixed the CI @ehuss.

@ehuss
Copy link
Copy Markdown
Contributor

ehuss commented Jun 1, 2026

Can you help me understand what is going on here? My understanding is that installing browser-ui-test also installs puppeteer. And puppeteer downloads a specific version of chromium (specified here I believe). Why does this need to download chromium? Wouldn't it make it less reproducible if the version of chromium isn't fixed?

@GuillaumeGomez
Copy link
Copy Markdown
Member Author

I have absolutely no clue why it suddenly stopped working. Maybe the puppeteer dependency version is too old. The layout rendering isn't supposed to change much between version so until I find a better solution, it will fix the CI for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: waiting on a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants