feat(replication): render structured active checks - #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compatibility with the legacy successful empty body
a default detailed trait method so other object-store implementations remain
source compatible
version-delete/cleanup results in stable human and output-v3 JSON
failed targets while still emitting the complete result
--yesin non-interactiveand JSON modes, with the active temporary mutation described before execution
bounded single-line errors, and optional contract version
URLs and endpoint details, and sanitize server-controlled terminal text
check_bucket_replication()failure semantics instead ofdiscarding a structured failed result
behavior
Compatibility
Existing output-v1 and protected command references are unchanged. The
output-v3
replication_operationsfamily already allows additive target/datafields, so existing resync fixtures remain byte-for-byte unchanged.
Older servers returning an empty HTTP 200 body continue to succeed, but the
client explicitly reports that no per-target or cleanup evidence is available.
Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test -p rc-s3 replication_check(6 passed)cargo test --workspace(all unit, integration, schema, golden, and doc testspassed on the final source)
workspace run passed when rerun alone and on the complete second workspace
run
git diff --checkAdversarial review:
Dependency
The structured service response is implemented by rustfs/rustfs#5208 and
rustfs/backlog#1417. Merge this PR after that dependency.
Closes rustfs/backlog#1496
Related: rustfs/backlog#1410, rustfs/backlog#1381, rustfs/backlog#1361