fix: unblock Windows/macOS release builds for rc tags - #15
Merged
Merged
Conversation
MSI rejects SemVer prereleases such as 1.0.0-rc.4, so Windows now bundles NSIS only. macOS builds app+dmg and can synthesize a signed updater archive when Tauri does not emit one. Intel macOS is skipped when upstream rustfs has no x86_64 zip, and latest.json lists only the platforms that actually shipped. Co-authored-by: RustFS <hello@rustfs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release run https://github.com/rustfs/launcher/actions/runs/33270190929 failed on every desktop target:
cargo tauri buildusedbundle.targets = "all", so it also built MSI. WiX rejects1.0.0-rc.4(optional pre-release identifier in app version must be numeric-only).cargo tauri build --bundles appproduced the.appbut not.app.tar.gz/.sig. The prepare step then failed with “未找到 macOS updater 产物或签名”.rustfs/rustfs@1.0.0-rc.4no longer publishesrustfs-macos-x86_64-*.zip(no assets match the file pattern).What changed
--bundles nsisonly.tauri.conf.jsontargets are nowapp,dmg, andnsis.--bundles app,dmg. If Tauri still does not emit an updater archive, the workflow packs the.appand signs it withcargo tauri signer.*-latest.zipand versioned names. When Intel macOS has no upstream zip, that matrix cell is skipped instead of failing the release.latest.jsonincludes only platforms that actually produced a signed updater file. Apple Silicon and Windows remain required.scripts/select-rustfs-asset.sh --self-testcovers the name matching and is run from CI.Tests
bash scripts/select-rustfs-asset.sh --self-testpython3 -m json.tool src-tauri/tauri.conf.json.github/workflows/build.ymlThe live
Build and Releaseworkflow still has to be re-run on tag1.0.0-rc.4after this merges.