fix(tls): bound generated SAN resource usage - #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Closes rustfs/backlog#1094
Summary of Changes
Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
CertificateInvalidbefore unsafe allocation or Kubernetes writes.Verification
make pre-commit cargo test reconcile::tls --lib -- --nocaptureAdditional Notes
Complete Kubernetes object checks use etcd's default 1.5 MiB request envelope with a 64 KiB protocol/admission margin. Reconcile-wide limits are 64 certificate entries, 16 MiB of PEM/Secret material, 8 MiB of parsed DER, and 16 MiB of estimated webpki SAN-scan work.
The final implementation was cross-reviewed for full-object accounting, aggregate multi-certificate work, wildcard compatibility, overflow behavior, and validation-before-expansion ordering.
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.