fix: patch Darwin liblzma linkage - #53
Merged
Merged
Conversation
Co-Authored-By: heihutu <heihutu@gmail.com>
houseme
force-pushed
the
houseme/fix-darwin-liblzma
branch
from
August 5, 2026 10:35
ad93238 to
2792e03
Compare
houseme
marked this pull request as ready for review
August 5, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the aarch64-darwin package so the prebuilt RustFS binary no longer depends on Homebrew's absolute
liblzmapath at runtime.Root Cause
The upstream macOS aarch64 release binary currently contains this Mach-O load command:
The flake installs the downloaded binary unchanged, so
packages.aarch64-darwin.defaultcan fail in a clean Nix environment where Homebrew's xz is not installed at that exact path.Changes
install_name_toolsupport during the package install phase.xzliblzma.5.dylibinto$out/lib.@executable_path/../lib/liblzma.5.dylib.Validation
git diff --checkjq empty sources.jsonactionlint.github/workflows/*.ymlLint and EvaluateBuild Linux package1.0.0-beta.12macOS aarch64 asset:sources.jsonotool -Lchanged from/opt/homebrew/opt/xz/lib/liblzma.5.dylibto@executable_path/../lib/liblzma.5.dylibcodesign --verify --verboseremained valid$out/bin/rustfs --helpran successfullyLocal
nixis not installed in this checkout environment, and the existing repository CI does not include a macOS package build job. A fullnix build .#packages.aarch64-darwin.defaultstill needs to be run in a Nix-enabled macOS environment.Fixes #51.