Repository navigation
Install fixes, skill dedupe, and CI #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
71d4c66
fix(scripts): detect untracked files in commit_changed_file.sh
cursoragent f8633a4
fix(dot): back up existing files on FORCE and drop duplicate jj link
cursoragent dfdc19b
fix(system): stop upgrading tools during install
cursoragent 7422afd
refactor(binutils): define SHARED_BINUTILS_PATH once in mise env
cursoragent ffa709f
fix(install): fail fast on errors and failed mise download
cursoragent 784a2f7
chore(skills): remove Codex copies of shared skills
cursoragent 2ff8828
chore(skills): symlink .claude repo skills to .agents copies
cursoragent c4868fb
fix(agent-review): fall back to git when jj is not installed
cursoragent 57ed105
feat(skills): add skills:check task for duplicated skills
cursoragent c459f84
ci: add shellcheck, skills, binutils, and agent-review checks
cursoragent 702ea10
docs: sync README, AGENTS.md, and specs with install changes
cursoragent 8ce4552
fix(dot): keep FORCE backups in one state directory
cursoragent f794237
fix(binutils): drop SHARED_BINUTILS_PATH override
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/dotfiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/dotfiles-tasks |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.agents/skills/nvim |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [master] | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| MISE_TRUSTED_CONFIG_PATHS: ${{ github.workspace }} | ||
|
|
||
| jobs: | ||
| shellcheck: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: shellcheck --severity=warning install scripts/* mise/tasks/install mise/tasks/*/* | ||
|
|
||
| skills: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: jdx/mise-action@v2 | ||
| with: | ||
| install: false | ||
| - run: mise run skills:check | ||
|
|
||
| binutils: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: packages/binutils | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # Cargo path dependencies expect shared_binutils as a sibling org checkout. | ||
| - run: git clone --depth 1 https://github.com/malleatus/shared_binutils.git "$GITHUB_WORKSPACE/../../malleatus/shared_binutils" | ||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: packages/binutils | ||
| - run: cargo fmt --check | ||
| - run: cargo clippy --all-targets -- -D warnings | ||
| - run: cargo test | ||
|
|
||
| agent-review: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: rhysd/action-setup-vim@v1 | ||
| with: | ||
| neovim: true | ||
| version: stable | ||
| - uses: jdx/mise-action@v2 | ||
| with: | ||
| install: false | ||
| - run: mise run agent-review:test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| #:schema https://mise.jdx.dev/schema/mise.json | ||
| min_version = "2025.10.0" | ||
|
|
||
| [env] | ||
| SHARED_BINUTILS_PATH = "{{ get_env(name='SHARED_BINUTILS_PATH', default=config_root ~ '/../../malleatus/shared_binutils') }}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
SHARED_BINUTILS_PATHpoints to a checkout outside the default location,binutils:installnow clones and builds that checkout, but the subsequent local build still resolveslatest_bin,test_utils, andfixturifythrough the hard-coded paths inpackages/binutils/Cargo.toml:25–27. On a machine without a checkout at the default location, installation therefore fails while loading those dependencies; if both locations exist, it builds against a different checkout than the one selected. Make dependency resolution use the selected checkout as well so the newly documented override works throughout installation.AGENTS.md reference: AGENTS.md:L13-L13
Useful? React with 👍 / 👎.