fix: add missing SF Symbol icons to menu items#1754
Merged
Conversation
Adds SF Symbol images to Settings, View Logging, and Check for Updates menu items in the status bar menu. - Settings: gear symbol - View Logging: doc.text symbol - Check for Updates: arrow.down.circle symbol Menu items are matched by action selector rather than title (localization-safe). Guarded with @available(macOS 11, *) since the project targets 10.15. Closes rxhanson#1741
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SF Symbol icons to the Settings, View Logging, and Check for Updates menu items in Rectangle's status bar menu.
Changes
Rectangle/AppDelegate.swift — new
addMenuIcons()method called inapplicationDidFinishLaunching(line 80):gearopenPreferences:doc.textviewLogging:arrow.down.circlecheckForUpdates:Menu items are matched by action selector rather than title text, which is resilient to localization changes. Guarded with
@available(macOS 11, *)since the project deployment target is macOS 10.15 and SF Symbols were introduced in macOS 11.Closes #1741