tmp: stage upstream #2716 custom-agent parallel tool calls - #18
Merged
sakitam-fdd merged 1 commit intoAug 21, 2026
Conversation
AgentEngine.executeToolCalls already branches to executeToolCallsParallel when AgentConfig.ParallelToolCalls is set, and that branch is fully implemented (errgroup, ordered result collection, best-effort siblings). But nothing ever set the flag: buildAgentConfig copies CustomAgentConfig into the runtime AgentConfig field by field, and this field was missing from both structs' bridge. The gate therefore always read the zero value, making executeToolCallsParallel unreachable for every custom agent. Add ParallelToolCalls to CustomAgentConfig and map it in buildAgentConfig. Defaults to false: tools are not required to be side-effect free, so agents saved before this option existed must keep running their tools sequentially. Enabling concurrency for them silently would be a behavior change rather than a fix.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sakitam-fdd
marked this pull request as ready for review
August 21, 2026 08:09
sakitam-fdd
merged commit Aug 21, 2026
8fe913d
into
sakitam-fdd:upstream-clean-2716-20260821
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary staging PR for Tencent#2716. It bridges the existing CustomAgent config into the already-implemented runtime parallel tool-call path, defaulting to false. This targets a current-main-derived staging branch for three-way validation.