feat: support safe manual plugin installs - #12
Open
0717lee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security
Non-npm sources are never passed to the DSH installer process. Manual commands are generated only from a strict validated source grammar; unsupported source strings are not echoed back to users.
Validation
npm run test:source(9 tests passed)npm pack --dry-runtsc --noCheckentry generation followed bypnpm --filter @sandbaseai/dsh-plugin-store bundlegit diff --checkThe full workspace
tsc -bremains blocked by existing Harness remote type errors and the existingpluginInventorytype mismatch; no new package-local type errors were reported after the changes.Closes #10