Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,54 @@ describe('Backspace delete', () => {

expect(inst.state.values).toHaveLength(2);
});

it('removes last value via onKeyDown on the select div (DOM path)', () => {
const component = selectWithProps(
<Select
multi
options={fixture}
values={[fixture[0], fixture[1]]}
labelField="name"
valueField="id"
placeholder=""
backspaceDelete
/>,
);

const inst = component.getInstance();
expect(inst.state.values).toHaveLength(2);

const selectDiv = findByClassName(component, 'react-dropdown-select');
TestRenderer.act(() => {
selectDiv.props.onKeyDown({ key: 'Backspace', preventDefault: () => {} });
});

expect(inst.state.values).toHaveLength(1);
expect(inst.state.values[0].name).toBe('Leanne Graham');
});

it('does not remove via onKeyDown when backspaceDelete is false (DOM path)', () => {
const component = selectWithProps(
<Select
multi
options={fixture}
values={[fixture[0], fixture[1]]}
labelField="name"
valueField="id"
backspaceDelete={false}
/>,
);

const inst = component.getInstance();
expect(inst.state.values).toHaveLength(2);

const selectDiv = findByClassName(component, 'react-dropdown-select');
TestRenderer.act(() => {
selectDiv.props.onKeyDown({ key: 'Backspace', preventDefault: () => {} });
});

expect(inst.state.values).toHaveLength(2);
});
});

describe('ArrowUp navigation', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dropdown-select/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const defaultProps: Partial<SelectProps<any>> = {
dropdownHandle: true,
dropdownHeight: '300px',
dropdownPosition: 'bottom',
handleKeyDownFn: () => undefined,
handleKeyDownFn: undefined,
keepOpen: false,
keepSelectedInList: true,
labelField: 'label',
Expand Down
Loading