Conversation
* Update strings.po * Fix typo
* Fix for force view mode The reaosn for the change: - Since the default view mode value for all the view types in the Elementum settings are equal to "0", Each navigation to any place in the addon force the view mode to be changed to "List" view (In my skin). --- Probably "Container.SetViewMode(0)" in Kodi 19.2 force it to be changed to "List" as default since there is no view mode id of "0" in my skin (And I guess in others too) - I also have another issue regarding to this: One of the Lists in Elementum is used as a widget in my skin. So on each refreshing of the widget (Kodi startup/Reload skin etc...) actually runs Elemetum which activate the force view mode changing. It cause that after each widget refreshing the first window in kodi that you navigate to it, its view mode will be changed according to what set in Elementum. The fix: It's so simple. If the view mode is equal to "0" (Which is the defaul value), don't do any view mode changing. Otherwise it will change it according to the Elementum settings. In this case, every change of the view modes inside Elementum by the skin context menu, the view mode is kept in Kodi/Skin/Addon cache or something (So at least I don't need this "Force" view mode changing). If for others these view mode changes are not kept in memory, they will need these options of "Force" changing and use it as always. It was tested and works well. Thanks. * Fix for force view mode - Condition fix * SetInfo doesn't have 'dbtype' key ListItem setInfo function has 'infoLabels' dictionary argument. But this dictionary doesn't have 'dbtype' key. This is why there was error of: ERROR <general>: NEWADDON Unknown Video Info Key "dbtype" The 'dbtype' only exist when getting the infoLabels from a ListItem. For more information: * ListItem setInfo: https://alwinesch.github.io/group__python__xbmcgui__listitem.html#ga0f1e91e1d5aa61d8dd0eac90e8edbf18 * ListItem info labels: https://kodi.wiki/view/InfoLabels#ListItem * SetInfo doesn't have 'dbtype' key ListItem setInfo function has 'infoLabels' dictionary argument. But this dictionary doesn't have 'dbtype' key. This is why there was error of: ' ERROR <general>: NEWADDON Unknown Video Info Key "dbtype" ' The 'dbtype' only exist when getting the infoLabels from a ListItem. Fix: Added a function for removing this 'dbtype' field before using the ListItem's 'setInfo' function For more information: * ListItem setInfo: https://alwinesch.github.io/group__python__xbmcgui__listitem.html#ga0f1e91e1d5aa61d8dd0eac90e8edbf18 * ListItem info labels: https://kodi.wiki/view/InfoLabels#ListItem * SetInfo doesn't have 'dbtype' key ListItem setInfo function has 'infoLabels' dictionary argument. But this dictionary doesn't have 'dbtype' key. This is why there was error of: ' ERROR <general>: NEWADDON Unknown Video Info Key "dbtype" ' The 'dbtype' only exist when getting the infoLabels from a ListItem. Fix: Added a function for removing this 'dbtype' field before using the ListItem's 'setInfo' function For more information: * ListItem setInfo: https://alwinesch.github.io/group__python__xbmcgui__listitem.html#ga0f1e91e1d5aa61d8dd0eac90e8edbf18 * ListItem info labels: https://kodi.wiki/view/InfoLabels#ListItem
* Update DialogInsert.xml There were problems with the appearance in various skins. Margins and some buttons were not well adapted to custom skins. * Update DialogSelectLarge.xml Fixing some visual bugs and skin polishing. There were also problems with displaying some buttons in custom skins.
* Visibility improvement Just a small improvement in visibility on darker skins. * Update DialogSelectLarge.xml
* Visibility improvement Just a small improvement in visibility on darker skins. * Update DialogInsert.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: